Dragging item in schedule up and down isn't consistent

Compare it to drag-and-drop from the song pane to the schedule pane. Click on a song (and keep the left mouse button pressed) and in one action:

  • the song is selected
  • the song can be dragged to the schedule

When I double-click a number of songs to the schedule and rearrange the schedule order: moving the last item wrongly selects the next to last item. See this video that also demonstrates the flickering between 2 items:

Also noted: if you move an imtermediate schedule item to the top of the schedule the separator line is shown (at the top). But if you move it to the bottom no line is shown. (not in the video)

“Latest” (14 days ago) Quelea CI release has issues with editing songs in the database. As soon as you make a single change to a song, the song completely disappears from the database and can’t be accessed. Also happens with videos too.

This has been resolved in the meantime.

1 Like

Thank you! and for spotting it too.

Test test and test again heh

Ok, more dragging fixes are up in the latest CI release (building now) - you should now be able to drag any item (even unselected) and the marker should appear even if you drag to the bottom of the list.

Dragging now works perfectly and intuitively :tada:

The bottom marker doesn’t show for me when dragging to the very bottom of the schedule, at least with the build from 2 hours ago, also doesn’t allow rearranging at the very bottom since it doesn’t appear in the first-place.

Hmm, do you never see it? It seems to work for me ok dragging items in the schedule to the bottom of the list.

I only see it on the last item in the list if I keep the schedule to a single page. Once the scroll bar appears, it no longer shows or works, versus the top one always working regardless of how far you are down even with the scrollbar.

Ah, gotcha - because there’s no “space” underneath the last item to drag it down, and dragging it down outside of the schedule pane means it doesn’t appear? I can reproduce that.

If there’s technically no “space” underneath the last item, then yes that would be the reason why.

…as in there’s no “empty” items in the scroll list - it’s “tight” to the bottom if that makes sense?

My findings in the latest CI.

  • When I click an unselected schedule item and hold the mouse button and start dragging the item: the info right next to the cursor should show the correct item name. This is not allways the case: a wrong item occurs or an empty item name.
  • When I click a schedule item first (to select it) and then re-click and drag it then the correct name is shown next to the cursor.

Additional:
The schedule contains 15 items. The wrong names are shown with the last 10 items. An empty name is shown with the first 5 items. Is there some hardcoding?

This should now be fixed.

(Afraid the issue with dragging a song to the bottom still isn’t there - I think this needs a bit more careful thought as to how I approach it. Hopefully I’ll get a fix out later this week for that one.)

Adding an empty item to the bottom of the list would be hacky, but would work. How does the furthermost-top rearrange method work currently? Is there an empty item there?

Yeah, “tight" to the bottom makes sense if we are on the same page.

Also dragging a song now always shows the item info next to it :tada: (easier to read too).

DeeTiglT’s additional issue with the wrong names being shown (item info while dragging) seems to be correlated to the songs that random flickering in the list when dragging an item. If the underlying problem was fixed, it’d stop the flicker and the info would have shown properly with no other changes (probably).

Nope - at the moment dragging an item positions it above the item it’s being dragged over, so no hack at the top is needed. The nice way would be to have dragging it over the top half of an item move it above the song, and the bottom half move it below the item, but JavaFX doesn’t make this sort of thing easy, unfortunately. It’s doable, but requires a bit more of a hack unfortunately!

The same is true of the flickering items - again the underlying UI toolkit is reporting a different item actually being dragged to the one that’s being shown. It’s a pain, but the ListView I’m working with wasn’t really designed for this sort of thing it seems. There might be a better fix there, but not one I’ve been able to find as of yet.

1 Like

Drag-and-drop an img from the img pane unto a schedule song: the img becomes the background img for the song. (this is also the 2022.0 behaviour)
But dragging this modified song to another position in the schedule causes an item duplication on each drag.

Drag-and-drop an vid from the vid pane unto a schedule song: the vid becomes the background vid for the song. (2022.0 does not have this)
Dragging this modified song to another position in the schedule does NOT causes item duplication.

Good spot - this should now be fixed.

Indeed, it is. :+1:

One minor: the moment you pick-up a schedule item with the mouse and the moment you drop it there is a little stuttering noticable in a playing live video (this doesn’t occur with 2022 + vlc). Perhaps some fine tuning with respect to GStreamer?

Thanks - I’ll take a look at the stuttering, but it might be something I can’t easily fix before the next release (which I’m hoping to get out early next year.)

Currently trying to focus on the memory leak issues - hoping to have some progress on that before Christmas!

1 Like